10 Sep, 2016

3 commits


09 Sep, 2016

1 commit


25 Aug, 2016

1 commit


24 Aug, 2016

2 commits


23 Aug, 2016

3 commits


02 Aug, 2016

2 commits


01 Aug, 2016

2 commits


30 Jul, 2016

1 commit


29 Jul, 2016

2 commits


26 Jul, 2016

1 commit


25 Jul, 2016

1 commit


23 Jul, 2016

2 commits


10 Jul, 2016

2 commits


09 Jul, 2016

1 commit


04 May, 2016

3 commits


03 May, 2016

1 commit


24 Apr, 2016

1 commit

  • Avoid extra string allocations on Index#document_type(record), which by default fallbacks to `model_name.to_s.underscore` which creates a new string object and call Inflector every time it used. Models already have `model_name.underscore`, which is frozen, we should you it to skip a generation of tons of strings inside a huge reindexing batch.
    Tõnis Simo
     

12 Mar, 2016

1 commit


11 Mar, 2016

1 commit

  • irb(main):001:0> User.reindex
    
    NoMethodError: undefined method `keys' for []:Array
    	from /app/vendor/bundle/ruby/2.1.0/gems/searchkick-1.2.1/lib/searchkick/index.rb:151:in `clean_indices'
    	from /app/vendor/bundle/ruby/2.1.0/gems/searchkick-1.2.1/lib/searchkick/index.rb:163:in `reindex_scope'
    	from /app/vendor/bundle/ruby/2.1.0/gems/searchkick-1.2.1/lib/searchkick/model.rb:51:in `searchkick_reindex'
    	from (irb):1
    	from /app/vendor/bundle/ruby/2.1.0/gems/railties-4.0.4/lib/rails/commands/console.rb:90:in `start'
    	from /app/vendor/bundle/ruby/2.1.0/gems/railties-4.0.4/lib/rails/commands/console.rb:9:in `start'
    	from /app/vendor/bundle/ruby/2.1.0/gems/railties-4.0.4/lib/rails/commands.rb:62:in `<top (required)>'
    	from bin/rails:4:in `require'
    	from bin/rails:4:in `<main>'
    
    When I looked into it, client.indices.get_alias returns a hash, not an array, so the NotFound rescue should be returning an empty hash.  This change fixes the issue.
    
    I did NOT add a unit test because the only way to test this would be to either nuke all indexes from the local ES test cluster, or startup a totally vanilla cluster just for running the test, which is kind of out of the scope of this change.
    Bernt Habermeier
     

19 Feb, 2016

1 commit


18 Feb, 2016

3 commits


17 Feb, 2016

2 commits


16 Feb, 2016

1 commit


15 Feb, 2016

2 commits