github / searchkick

Download as
Browse Code ยป

Commit ef500c8d0e640c7f88562c9699a1527f3bb9e0fa

Authored by Andrew Kane
1 parent 8022b7b1
Exists in master and in 21 other branches allow_missing, conversions_period, conversions_v2, eager_load, find_in_batches, highlighted, index_name, lazy_index_name, less_deps, nested, reindex_async_threads, reindex_refactor, relation, relation_search, routing_queue, scope_attributes, search_as_you_type, synonyms_ci, test_language, threads, wildcard

Fix for Ruby 2.0 - fixes #698

Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
lib/searchkick.rb
  Diff comments   View file @ef500c8
... ... @@ -59,7 +59,7 @@ module Searchkick
59 59 end
60 60  
61 61 def self.server_below?(version)
62   - Gem::Version.new(server_version) < Gem::Version.new(version)
  62 + Gem::Version.new(server_version.sub("-", ".")) < Gem::Version.new(version.sub("-", "."))
63 63 end
64 64  
65 65 def self.enable_callbacks
... ...
test/aggs_test.rb
  Diff comments   View file @ef500c8
... ... @@ -42,7 +42,7 @@ class AggsTest &lt; Minitest::Test
42 42 agg = Product.search("Product", aggs: {store_id: {limit: 1}}).aggs["store_id"]
43 43 assert_equal 1, agg["buckets"].size
44 44 # assert_equal 3, agg["doc_count"]
45   - assert_equal(1, agg["sum_other_doc_count"]) if Gem::Version.new(Searchkick.server_version) >= Gem::Version.new("1.4.0")
  45 + assert_equal(1, agg["sum_other_doc_count"]) unless Searchkick.server_below?("1.4.0")
46 46 end
47 47  
48 48 def test_ranges
... ...