Remove posix-spawn dependency

Jason Lee
1 parent 248c90f9
Showing 3 changed files with 9 additions and 9 deletions Show diff stats
CHANGELOG.md
letter_avatar.gemspec
lib/letter_avatar.rb
+0.2.0
+-----
+
+- Removed `posix-spawn` dependency, Open3 speed is ok.
+
 0.1.11
 ------
  
-- Windows support
+- Windows support.
  
 0.1.10
 ------
@@ -16,6 +16,5 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
  
-  spec.add_dependency 'posix-spawn', '>= 0.3.0'
   spec.add_dependency 'activesupport', '>= 3.0.0'
 end
-require 'posix/spawn'
+require 'open3'
  
 require 'letter_avatar/version'
 require 'letter_avatar/configuration'
@@ -43,14 +43,10 @@ module LetterAvatar
   def self.execute(cmd)
     cmd = cmd.join(' ') if cmd.is_a?(Array)
     if Gem.win_platform?
-      require 'open3'
-      _stdout_str, err = Open3.capture3(cmd.tr("'", '"'))
-    else
-      pid, _stdin, _stdout, stderr = POSIX::Spawn.popen4(cmd)
-      Process.waitpid(pid)
-      err = stderr.read
+      cmd.tr!("'", '"')
     end
  
+    _stdout_str, err = Open3.capture3(cmd)
     if !err.nil? && !err.empty?
       raise ExecutionError.new("letter_avatar execution error (when calling '#{cmd}'): '#{err.strip}'")
     end
	1	+0.2.0
	2	+-----
	3	+
	4	+- Removed `posix-spawn` dependency, Open3 speed is ok.
	5	+
1	6	0.1.11
2	7	------
3	8
4		-- Windows support
	9	+- Windows support.
5	10
6	11	0.1.10
7	12	------
...	...
...	...	@@ -16,6 +16,5 @@ Gem::Specification.new do \|spec\|
16	16	spec.test_files = spec.files.grep(%r{^(test\|spec\|features)/})
17	17	spec.require_paths = ['lib']
18	18
19		- spec.add_dependency 'posix-spawn', '>= 0.3.0'
20	19	spec.add_dependency 'activesupport', '>= 3.0.0'
21	20	end
...	...
1		-require 'posix/spawn'
	1	+require 'open3'
2	2
3	3	require 'letter_avatar/version'
4	4	require 'letter_avatar/configuration'
...	...	@@ -43,14 +43,10 @@ module LetterAvatar
43	43	def self.execute(cmd)
44	44	cmd = cmd.join(' ') if cmd.is_a?(Array)
45	45	if Gem.win_platform?
46		- require 'open3'
47		- _stdout_str, err = Open3.capture3(cmd.tr("'", '"'))
48		- else
49		- pid, _stdin, _stdout, stderr = POSIX::Spawn.popen4(cmd)
50		- Process.waitpid(pid)
51		- err = stderr.read
	46	+ cmd.tr!("'", '"')
52	47	end
53	48
	49	+ _stdout_str, err = Open3.capture3(cmd)
54	50	if !err.nil? && !err.empty?
55	51	raise ExecutionError.new("letter_avatar execution error (when calling '#{cmd}'): '#{err.strip}'")
56	52	end
...	...