Merge pull request #26 from petergoldstein/feature/add_respond_to

respond_to? doesn't return true for dynamic methods added by method_missing

Merge pull request #26 from petergoldstein/feature/add_respond_to
respond_to? doesn't return true for dynamic methods added by method_missing
Tom Cocca
2 parents 208ad563 85a61ff6
Showing 5 changed files with 33 additions and 2 deletions Show diff stats
acts_as_follower.gemspec
lib/acts_as_follower/followable.rb
lib/acts_as_follower/follower.rb
test/acts_as_followable_test.rb
test/acts_as_follower_test.rb
@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
  
   s.add_development_dependency "sqlite3"
   s.add_development_dependency "shoulda_create"
-  s.add_development_dependency "shoulda", "3.5.0"
-  s.add_development_dependency "factory_girl", "4.2.0"
+  s.add_development_dependency "shoulda", ">= 3.5.0"
+  s.add_development_dependency "factory_girl", ">= 4.2.0"
   s.add_development_dependency "rails", "~> 4.0.0"
 end
@@ -55,6 +55,10 @@ module ActsAsFollower #:nodoc:
         end
       end
  
+      def respond_to?(m, include_private = false)
+        super || m.to_s[/count_(.+)_followers/] || m.to_s[/(.+)_followers/]
+      end
+
       def blocked_followers_count
         self.followings.blocked.count
       end
@@ -97,6 +97,10 @@ module ActsAsFollower #:nodoc:
         end
       end
  
+      def respond_to?(m, include_private = false)
+        super || m.to_s[/following_(.+)_count/] || m.to_s[/following_(.+)/]
+      end
+
       # Returns a follow record for the current instance and followable object.
       def get_follow(followable)
         self.follows.unblocked.for_followable(followable).first
@@ -251,6 +251,18 @@ class ActsAsFollowableTest &lt; ActiveSupport::TestCase
         assert_equal 1, @oasis.count_user_followers
       end
     end
+
+    context "respond_to?" do
+      should "advertise that it responds to following methods" do
+        assert @oasis.respond_to?(:user_followers)
+        assert @oasis.respond_to?(:user_followers_count)
+      end
+
+      should "return false when called with a nonexistent method" do
+        assert (not @oasis.respond_to?(:foobar))
+      end
+    end
+
   end
  
 end
@@ -173,6 +173,17 @@ class ActsAsFollowerTest &lt; ActiveSupport::TestCase
       end
     end
  
+    context "respond_to?" do
+      should "advertise that it responds to following methods" do
+        assert @sam.respond_to?(:following_users)
+        assert @sam.respond_to?(:following_users_count)
+      end
+
+      should "return false when called with a nonexistent method" do
+        assert (not @sam.respond_to?(:foobar))
+      end
+    end
+
     context "destroying follower" do
       setup do
         @jon.destroy
...	...	@@ -21,7 +21,7 @@ Gem::Specification.new do \|s\|
21	21
22	22	s.add_development_dependency "sqlite3"
23	23	s.add_development_dependency "shoulda_create"
24		- s.add_development_dependency "shoulda", "3.5.0"
25		- s.add_development_dependency "factory_girl", "4.2.0"
	24	+ s.add_development_dependency "shoulda", ">= 3.5.0"
	25	+ s.add_development_dependency "factory_girl", ">= 4.2.0"
26	26	s.add_development_dependency "rails", "~> 4.0.0"
27	27	end
...	...
...	...	@@ -55,6 +55,10 @@ module ActsAsFollower #:nodoc:
55	55	end
56	56	end
57	57
	58	+ def respond_to?(m, include_private = false)
	59	+ super \|\| m.to_s[/count_(.+)_followers/] \|\| m.to_s[/(.+)_followers/]
	60	+ end
	61	+
58	62	def blocked_followers_count
59	63	self.followings.blocked.count
60	64	end
...	...
...	...	@@ -97,6 +97,10 @@ module ActsAsFollower #:nodoc:
97	97	end
98	98	end
99	99
	100	+ def respond_to?(m, include_private = false)
	101	+ super \|\| m.to_s[/following_(.+)_count/] \|\| m.to_s[/following_(.+)/]
	102	+ end
	103	+
100	104	# Returns a follow record for the current instance and followable object.
101	105	def get_follow(followable)
102	106	self.follows.unblocked.for_followable(followable).first
...	...
...	...	@@ -251,6 +251,18 @@ class ActsAsFollowableTest < ActiveSupport::TestCase
251	251	assert_equal 1, @oasis.count_user_followers
252	252	end
253	253	end
	254	+
	255	+ context "respond_to?" do
	256	+ should "advertise that it responds to following methods" do
	257	+ assert @oasis.respond_to?(:user_followers)
	258	+ assert @oasis.respond_to?(:user_followers_count)
	259	+ end
	260	+
	261	+ should "return false when called with a nonexistent method" do
	262	+ assert (not @oasis.respond_to?(:foobar))
	263	+ end
	264	+ end
	265	+
254	266	end
255	267
256	268	end
...	...
...	...	@@ -173,6 +173,17 @@ class ActsAsFollowerTest < ActiveSupport::TestCase
173	173	end
174	174	end
175	175
	176	+ context "respond_to?" do
	177	+ should "advertise that it responds to following methods" do
	178	+ assert @sam.respond_to?(:following_users)
	179	+ assert @sam.respond_to?(:following_users_count)
	180	+ end
	181	+
	182	+ should "return false when called with a nonexistent method" do
	183	+ assert (not @sam.respond_to?(:foobar))
	184	+ end
	185	+ end
	186	+
176	187	context "destroying follower" do
177	188	setup do
178	189	@jon.destroy
...	...