github / searchkick

25 Aug, 2016

1 commit

ebd9bdfa Fixed error with word - #716 Browse File »

Andrew Kane
2016-08-25 08:56:09 -0700

23 Aug, 2016

1 commit

b03fef75 Added resume option to reindex Browse File »

Andrew Kane
2016-08-23 22:23:05 -0700

02 Aug, 2016

1 commit

83fc70e4 Revert "Merge pull request #662 from estum/fix_document_type" ... Browse File »
```
This reverts commit 7814670db850b286a190f5db5b8c5e30bf72e965, reversing
changes made to 686c4ac634dfd4f0810768ce878ed16fb894ec82.
```
Andrew Kane
2016-08-02 00:17:29 -0700

29 Jul, 2016

2 commits

907b5249 Merge pull request #708 from meetrajesh/boost_any_conversions_field ... Browse File »
```
Support conversion boosting on multiple fields
```
Andrew Kane
2016-07-29 16:45:04 -0700
0d315179 Support conversion boosting on multiple fields Browse File »

Rajesh Kumar
2016-07-29 16:25:32 -0700

23 Jul, 2016

1 commit

7814670d Merge pull request #662 from estum/fix_document_type ... Browse File »
```
Avoid extra string allocations
```
Andrew Kane
2016-07-23 18:41:45 -0700

09 Jul, 2016

1 commit

8022b7b1 Set ignore above when other options are specified - fixes #696 Browse File »

Andrew Kane
2016-07-09 13:52:43 -0700

04 May, 2016

1 commit

668b7948 Added support for Elasticsearch 5.0 alpha Browse File »

Andrew Kane
2016-05-04 02:35:49 -0700

24 Apr, 2016

1 commit

e0e76c92 Avoid extra string allocations ... Browse File »

Avoid extra string allocations on Index#document_type(record), which by default fallbacks to `model_name.to_s.underscore` which creates a new string object and call Inflector every time it used. Models already have `model_name.underscore`, which is frozen, we should you it to skip a generation of tons of strings inside a huge reindexing batch.

2016-04-24 04:56:22 +0300

12 Mar, 2016

1 commit

7a197b38 Merge pull request #645 from habermeier/fix_no_indicies ... Browse File »
```
reindexing models on an ES cluster that is totally new / empty throws…
```
Andrew Kane
2016-03-12 11:27:09 -0800

11 Mar, 2016

1 commit

1352b808 reindexing models on an ES cluster that is totally new / empty throws the following exception: ... Browse File »

irb(main):001:0> User.reindex

NoMethodError: undefined method `keys' for []:Array
	from /app/vendor/bundle/ruby/2.1.0/gems/searchkick-1.2.1/lib/searchkick/index.rb:151:in `clean_indices'
	from /app/vendor/bundle/ruby/2.1.0/gems/searchkick-1.2.1/lib/searchkick/index.rb:163:in `reindex_scope'
	from /app/vendor/bundle/ruby/2.1.0/gems/searchkick-1.2.1/lib/searchkick/model.rb:51:in `searchkick_reindex'
	from (irb):1
	from /app/vendor/bundle/ruby/2.1.0/gems/railties-4.0.4/lib/rails/commands/console.rb:90:in `start'
	from /app/vendor/bundle/ruby/2.1.0/gems/railties-4.0.4/lib/rails/commands/console.rb:9:in `start'
	from /app/vendor/bundle/ruby/2.1.0/gems/railties-4.0.4/lib/rails/commands.rb:62:in `<top (required)>'
	from bin/rails:4:in `require'
	from bin/rails:4:in `<main>'

When I looked into it, client.indices.get_alias returns a hash, not an array, so the NotFound rescue should be returning an empty hash.  This change fixes the issue.

I did NOT add a unit test because the only way to test this would be to either nuke all indexes from the local ES test cluster, or startup a totally vanilla cluster just for running the test, which is kind of out of the scope of this change.