Strip spaces from synonyms and added notice about two word max - fixes #913

Andrew
1 parent 3b0eb3c6
Showing 3 changed files with 5 additions and 2 deletions Show diff stats
README.md
lib/searchkick/index_options.rb
test/test_helper.rb
@@ -299,6 +299,8 @@ end
  
 Call `Product.reindex` after changing synonyms.
  
+Synonyms cannot be more than two words at the moment.
+
 To read synonyms from a file, use:
  
 ```ruby
@@ -174,7 +174,8 @@ module Searchkick
         if synonyms.any?
           settings[:analysis][:filter][:searchkick_synonym] = {
             type: "synonym",
-            synonyms: synonyms.select { |s| s.size > 1 }.map { |s| s.is_a?(Array) ? s.join(",") : s }.map(&:downcase)
+            # only remove a single space from synonyms so three-word synonyms will fail noisily instead of silently
+            synonyms: synonyms.select { |s| s.size > 1 }.map { |s| s.is_a?(Array) ? s.map { |s| s.sub(/\s+/, "") }.join(",") : s }.map(&:downcase)
           }
           # choosing a place for the synonym filter when stemming is not easy
           # https://groups.google.com/forum/#!topic/elasticsearch/p7qcQlgHdB8
@@ -399,7 +399,7 @@ class Product
     synonyms: [
       ["clorox", "bleach"],
       ["scallion", "greenonion"],
-      ["saranwrap", "plasticwrap"],
+      ["saran wrap", "plastic wrap"],
       ["qtip", "cottonswab"],
       ["burger", "hamburger"],
       ["bandaid", "bandag"],
...	...	@@ -299,6 +299,8 @@ end
299	299
300	300	Call `Product.reindex` after changing synonyms.
301	301
	302	+Synonyms cannot be more than two words at the moment.
	303	+
302	304	To read synonyms from a file, use:
303	305
304	306	```ruby
...	...
...	...	@@ -174,7 +174,8 @@ module Searchkick
174	174	if synonyms.any?
175	175	settings[:analysis][:filter][:searchkick_synonym] = {
176	176	type: "synonym",
177		- synonyms: synonyms.select { \|s\| s.size > 1 }.map { \|s\| s.is_a?(Array) ? s.join(",") : s }.map(&:downcase)
	177	+ # only remove a single space from synonyms so three-word synonyms will fail noisily instead of silently
	178	+ synonyms: synonyms.select { \|s\| s.size > 1 }.map { \|s\| s.is_a?(Array) ? s.map { \|s\| s.sub(/\s+/, "") }.join(",") : s }.map(&:downcase)
178	179	}
179	180	# choosing a place for the synonym filter when stemming is not easy
180	181	# https://groups.google.com/forum/#!topic/elasticsearch/p7qcQlgHdB8
...	...
...	...	@@ -399,7 +399,7 @@ class Product
399	399	synonyms: [
400	400	["clorox", "bleach"],
401	401	["scallion", "greenonion"],
402		- ["saranwrap", "plasticwrap"],
	402	+ ["saran wrap", "plastic wrap"],
403	403	["qtip", "cottonswab"],
404	404	["burger", "hamburger"],
405	405	["bandaid", "bandag"],
...	...