Use missing_hits instead of missing_ids

Andrew Kane
1 parent 9a69a9fe
Showing 3 changed files with 14 additions and 14 deletions Show diff stats
CHANGELOG.md
lib/searchkick/results.rb
test/search_test.rb
 ## 4.4.2 (unreleased)
-- Added `missing_ids` method to results
+- Added `missing_hits` method to results
 - Fixed issue with `like` and special characters
 ## 4.4.1 (2020-06-24)
@@ -22,15 +22,15 @@ module Searchkick
     # TODO return enumerator like with_score
     def with_hit
       @with_hit ||= begin
-        if missing_ids.any?
-          Searchkick.warn("Records in search index do not exist in database: #{missing_ids.join(", ")}")
+        if missing_hits.any?
+          Searchkick.warn("Records in search index do not exist in database: #{missing_hits.map { |v| v["_id"] }.join(", ")}")
         end
-        with_hit_and_missing_ids[0]
+        with_hit_and_missing_hits[0]
       end
     end
-    def missing_ids
-      @missing_ids ||= with_hit_and_missing_ids[1]
+    def missing_hits
+      @missing_hits ||= with_hit_and_missing_hits[1]
     end
     def suggestions
@@ -219,9 +219,9 @@ module Searchkick
     private
-    def with_hit_and_missing_ids
-      @with_hit_and_missing_ids ||= begin
-        missing_ids = []
+    def with_hit_and_missing_hits
+      @with_hit_and_missing_hits ||= begin
+        missing_hits = []
         if options[:load]
           # results can have different types
@@ -257,7 +257,7 @@ module Searchkick
               end
               [result, hit]
             end.select do |result, hit|
-              missing_ids << hit["_id"] unless result
+              missing_hits << hit unless result
               result
             end
         else
@@ -284,7 +284,7 @@ module Searchkick
             end
         end
-       [results, missing_ids]
+       [results, missing_hits]
       end
     end
@@ -37,16 +37,16 @@ class SearchTest &lt; Minitest::Test
     assert_equal ["Dollar Tree"], products.map(&:name)
   end
-  def test_missing_ids
+  def test_missing_hits
     store_names ["Product A", "Product B"]
     product = Product.find_by(name: "Product A")
     product.delete
     assert_output nil, /\[searchkick\] WARNING: Records in search index do not exist in database/ do
       result = Product.search("product")
       assert_equal ["Product B"], result.map(&:name)
-      assert_equal [product.id.to_s], result.missing_ids
+      assert_equal [product.id.to_s], result.missing_hits.map { |v| v["_id"] }
     end
-    assert_equal [], Product.search("product", load: false).missing_ids
+    assert_empty Product.search("product", load: false).missing_hits
   ensure
     Product.reindex
   end
1	## 4.4.2 (unreleased)	1	## 4.4.2 (unreleased)
2		2
3	-- Added `missing_ids` method to results	3	+- Added `missing_hits` method to results
4	- Fixed issue with `like` and special characters	4	- Fixed issue with `like` and special characters
5		5
6	## 4.4.1 (2020-06-24)	6	## 4.4.1 (2020-06-24)
	@@ -37,16 +37,16 @@ class SearchTest < Minitest::Test		@@ -37,16 +37,16 @@ class SearchTest < Minitest::Test
37	assert_equal ["Dollar Tree"], products.map(&:name)	37	assert_equal ["Dollar Tree"], products.map(&:name)
38	end	38	end
39		39
40	- def test_missing_ids	40	+ def test_missing_hits
41	store_names ["Product A", "Product B"]	41	store_names ["Product A", "Product B"]
42	product = Product.find_by(name: "Product A")	42	product = Product.find_by(name: "Product A")
43	product.delete	43	product.delete
44	assert_output nil, /\[searchkick\] WARNING: Records in search index do not exist in database/ do	44	assert_output nil, /\[searchkick\] WARNING: Records in search index do not exist in database/ do
45	result = Product.search("product")	45	result = Product.search("product")
46	assert_equal ["Product B"], result.map(&:name)	46	assert_equal ["Product B"], result.map(&:name)
47	- assert_equal [product.id.to_s], result.missing_ids	47	+ assert_equal [product.id.to_s], result.missing_hits.map { \|v\| v["_id"] }
48	end	48	end
49	- assert_equal [], Product.search("product", load: false).missing_ids	49	+ assert_empty Product.search("product", load: false).missing_hits
50	ensure	50	ensure
51	Product.reindex	51	Product.reindex
52	end	52	end