Added support for endless ranges

Andrew Kane
1 parent 2ca8cbd4
Showing 3 changed files with 12 additions and 1 deletions Show diff stats
CHANGELOG.md
lib/searchkick/query.rb
test/where_test.rb
 ## 3.1.3 [unreleased]
+- Added support for endless ranges
 - Added `prefix` to `where`
 - Fixed error with some language stemmers and Elasticsearch 6.5
@@ -843,7 +843,12 @@ module Searchkick
         else
           # expand ranges
           if value.is_a?(Range)
-            value = {gte: value.first, (value.exclude_end? ? :lt : :lte) => value.last}
+            # infinite? added in Ruby 2.4
+            if value.end.nil? || (value.end.respond_to?(:infinite?) && value.end.infinite?)
+              value = {gte: value.first}
+            else
+              value = {gte: value.first, (value.exclude_end? ? :lt : :lte) => value.last}
+            end
           end
           value = {in: value} if value.is_a?(Array)
@@ -35,6 +35,11 @@ class WhereTest &lt; Minitest::Test
     assert_search "product", ["Product C", "Product D"], where: {store_id: {not: [1, 2]}}
     assert_search "product", ["Product C", "Product D"], where: {store_id: {_not: [1, 2]}}
     assert_search "product", ["Product A"], where: {user_ids: {lte: 2, gte: 2}}
+    assert_search "product", ["Product C", "Product D"], where: {store_id: 3..Float::INFINITY}
+    if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6.0")
+      # use eval to prevent parse error
+      assert_search "product", ["Product C", "Product D"], where: {store_id: 3..eval("0..")}
+    end
     # or
     assert_search "product", ["Product A", "Product B", "Product C"], where: {or: [[{in_stock: true}, {store_id: 3}]]}
1	## 3.1.3 [unreleased]	1	## 3.1.3 [unreleased]
2		2
		3	+- Added support for endless ranges
3	- Added `prefix` to `where`	4	- Added `prefix` to `where`
4	- Fixed error with some language stemmers and Elasticsearch 6.5	5	- Fixed error with some language stemmers and Elasticsearch 6.5
5		6