Fixed Relation loaded error for non-mutating methods on relation - #1395

Andrew Kane
1 parent 8a0303c5
Showing 3 changed files with 9 additions and 0 deletions Show diff stats
CHANGELOG.md
lib/searchkick/relation.rb
test/relation_test.rb
@@ -3,6 +3,7 @@
 - Added `model` method to `Searchkick::Relation`
 - Fixed deprecation warning with `redis` gem
 - Fixed `respond_to?` method on relation loading relation
+- Fixed `Relation loaded` error for non-mutating methods on relation
  
 ## 5.0.4 (2022-06-16)
  
@@ -233,5 +233,10 @@ module Searchkick
     def ensure_permitted(obj)
       obj.to_h
     end
+
+    def initialize_copy(other)
+      super
+      @execute = nil
+    end
   end
 end
@@ -7,6 +7,9 @@ class RelationTest &lt; Minitest::Test
     refute products.loaded?
     assert_equal 0, products.count
     assert products.loaded?
+    refute products.clone.loaded?
+    refute products.dup.loaded?
+    refute products.limit(2).loaded?
     error = assert_raises(Searchkick::Error) do
       products.limit!(2)
     end
...	...	@@ -3,6 +3,7 @@
3	3	- Added `model` method to `Searchkick::Relation`
4	4	- Fixed deprecation warning with `redis` gem
5	5	- Fixed `respond_to?` method on relation loading relation
	6	+- Fixed `Relation loaded` error for non-mutating methods on relation
6	7
7	8	## 5.0.4 (2022-06-16)
8	9
...	...
...	...	@@ -233,5 +233,10 @@ module Searchkick
233	233	def ensure_permitted(obj)
234	234	obj.to_h
235	235	end
	236	+
	237	+ def initialize_copy(other)
	238	+ super
	239	+ @execute = nil
	240	+ end
236	241	end
237	242	end
...	...
...	...	@@ -7,6 +7,9 @@ class RelationTest < Minitest::Test
7	7	refute products.loaded?
8	8	assert_equal 0, products.count
9	9	assert products.loaded?
	10	+ refute products.clone.loaded?
	11	+ refute products.dup.loaded?
	12	+ refute products.limit(2).loaded?
10	13	error = assert_raises(Searchkick::Error) do
11	14	products.limit!(2)
12	15	end
...	...