Always add callbacks for bulk updates

Andrew Kane
1 parent 0614e889
Showing 2 changed files with 7 additions and 9 deletions Show diff stats
README.md
lib/searchkick/model.rb
@@ -406,7 +406,7 @@ There are three strategies for keeping the index synced with your database.
   end
   ```
-For better performance, you can also do bulk updates. [master]
+You can also do bulk updates. [master]
 ```ruby
 Searchkick.callbacks(:bulk) do
@@ -70,14 +70,12 @@ module Searchkick
         end
         extend Searchkick::Reindex # legacy for Searchjoy
-        if callbacks
-          callback_name = callbacks == :async ? :reindex_async : :reindex
-          if respond_to?(:after_commit)
-            after_commit callback_name, if: proc { self.class.search_callbacks? }
-          else
-            after_save callback_name, if: proc { self.class.search_callbacks? }
-            after_destroy callback_name, if: proc { self.class.search_callbacks? }
-          end
+        callback_name = callbacks == :async ? :reindex_async : :reindex
+        if respond_to?(:after_commit)
+          after_commit callback_name, if: proc { self.class.search_callbacks? }
+        else
+          after_save callback_name, if: proc { self.class.search_callbacks? }
+          after_destroy callback_name, if: proc { self.class.search_callbacks? }
         end
         def reindex
	@@ -406,7 +406,7 @@ There are three strategies for keeping the index synced with your database.		@@ -406,7 +406,7 @@ There are three strategies for keeping the index synced with your database.
406	end	406	end
407	```	407	```
408		408
409	-For better performance, you can also do bulk updates. [master]	409	+You can also do bulk updates. [master]
410		410
411	```ruby	411	```ruby
412	Searchkick.callbacks(:bulk) do	412	Searchkick.callbacks(:bulk) do