Better exception when trying to access results for failed multi-search query - fixes #1032

Andrew
1 parent fc62c49a
Showing 3 changed files with 12 additions and 5 deletions Show diff stats
CHANGELOG.md
lib/searchkick/results.rb
test/multi_search_test.rb
 ## 2.4.1 [unreleased]
  
+- Better exception when trying to access results for failed multi-search query
 - Added support for `faraday_middleware-aws-sigv4`
 - Added `credentials` option to `aws_credentials`
  
@@ -187,7 +187,11 @@ module Searchkick
     end
  
     def hits
-      @response["hits"]["hits"]
+      if error
+        raise Searchkick::Error, "Query error - use the error method to view it"
+      else
+        @response["hits"]["hits"]
+      end
     end
  
     def misspellings?
@@ -34,9 +34,11 @@ class MultiSearchTest &lt; Minitest::Test
     assert_equal ["abc", "abd"], products.map(&:name)
   end
  
-  # https://github.com/ankane/searchkick/issues/1032
-  def test_no_records
-    products = Product.search("*", order: {created_at: :asc}, execute: false)
-    assert Searchkick.multi_search([products])[0].results
+  def test_error
+    products = Product.search("*", order: {bad_column: :asc}, execute: false)
+    Searchkick.multi_search([products])
+    assert products.error
+    error = assert_raises(Searchkick::Error) { products.results }
+    assert_equal error.message, "Query error - use the error method to view it"
   end
 end
1	1	## 2.4.1 [unreleased]
2	2
	3	+- Better exception when trying to access results for failed multi-search query
3	4	- Added support for `faraday_middleware-aws-sigv4`
4	5	- Added `credentials` option to `aws_credentials`
5	6
...	...
...	...	@@ -187,7 +187,11 @@ module Searchkick
187	187	end
188	188
189	189	def hits
190		- @response["hits"]["hits"]
	190	+ if error
	191	+ raise Searchkick::Error, "Query error - use the error method to view it"
	192	+ else
	193	+ @response["hits"]["hits"]
	194	+ end
191	195	end
192	196
193	197	def misspellings?
...	...
...	...	@@ -34,9 +34,11 @@ class MultiSearchTest < Minitest::Test
34	34	assert_equal ["abc", "abd"], products.map(&:name)
35	35	end
36	36
37		- # https://github.com/ankane/searchkick/issues/1032
38		- def test_no_records
39		- products = Product.search("*", order: {created_at: :asc}, execute: false)
40		- assert Searchkick.multi_search([products])[0].results
	37	+ def test_error
	38	+ products = Product.search("*", order: {bad_column: :asc}, execute: false)
	39	+ Searchkick.multi_search([products])
	40	+ assert products.error
	41	+ error = assert_raises(Searchkick::Error) { products.results }
	42	+ assert_equal error.message, "Query error - use the error method to view it"
41	43	end
42	44	end
...	...