Commit 6e6e921314ce9f9af47719ff003373cebc9007a0
1 parent
ee58d740
Exists in
master
and in
15 other branches
Updated comment [skip ci]
Showing
1 changed file
with
3 additions
and
2 deletions
Show diff stats
lib/searchkick/query.rb
| @@ -435,8 +435,9 @@ module Searchkick | @@ -435,8 +435,9 @@ module Searchkick | ||
| 435 | if models.any? { |m| m != m.searchkick_klass } | 435 | if models.any? { |m| m != m.searchkick_klass } |
| 436 | Searchkick.warn("Passing child models to models option throws off hits and pagination - use type option instead") | 436 | Searchkick.warn("Passing child models to models option throws off hits and pagination - use type option instead") |
| 437 | 437 | ||
| 438 | - # uncomment once aliases are supported with _index | ||
| 439 | - # see https://github.com/elastic/elasticsearch/issues/23306 | 438 | + # TODO uncomment once aliases are supported with _index |
| 439 | + # should be ES 7.5 | ||
| 440 | + # see https://github.com/elastic/elasticsearch/pull/46640 | ||
| 440 | # index_type_or = | 441 | # index_type_or = |
| 441 | # models.map do |m| | 442 | # models.map do |m| |
| 442 | # v = {_index: m.searchkick_index.name} | 443 | # v = {_index: m.searchkick_index.name} |