Raise warning when search called on relation

Andrew Kane
1 parent 642ec519
Showing 2 changed files with 15 additions and 0 deletions Show diff stats
lib/searchkick/model.rb
test/match_test.rb
@@ -41,6 +41,8 @@ module Searchkick
         class << self
           def searchkick_search(term = "*", **options, &block)
+            # TODO same for Mongoid
+            Searchkick.warn("calling search on a relation is deprecated") if respond_to?(:current_scope) && !current_scope.nil?
             Searchkick.search(term, model: self, **options, &block)
           end
           alias_method Searchkick.search_method_name, :searchkick_search if Searchkick.search_method_name
@@ -301,4 +301,17 @@ class MatchTest &lt; Minitest::Test
     store_names ["Ice Cream Cake"]
     assert_search "🍨🍰", ["Ice Cream Cake"], emoji: true
   end
+
+  # TODO find better place
+
+  def test_search_relation
+    skip unless defined?(ActiveRecord)
+
+    assert_nil Product.current_scope
+    _, stderr = capture_io { Product.search("*") }
+    assert_equal "", stderr
+    assert Product.where(name: nil).current_scope
+    _, stderr = capture_io { Product.where(name: nil).search("*") }
+    assert_match "WARNING", stderr
+  end
 end
	@@ -301,4 +301,17 @@ class MatchTest < Minitest::Test		@@ -301,4 +301,17 @@ class MatchTest < Minitest::Test
301	store_names ["Ice Cream Cake"]	301	store_names ["Ice Cream Cake"]
302	assert_search "🍨🍰", ["Ice Cream Cake"], emoji: true	302	assert_search "🍨🍰", ["Ice Cream Cake"], emoji: true
303	end	303	end
		304	+
		305	+ # TODO find better place
		306	+
		307	+ def test_search_relation
		308	+ skip unless defined?(ActiveRecord)
		309	+
		310	+ assert_nil Product.current_scope
		311	+ _, stderr = capture_io { Product.search("*") }
		312	+ assert_equal "", stderr
		313	+ assert Product.where(name: nil).current_scope
		314	+ _, stderr = capture_io { Product.where(name: nil).search("*") }
		315	+ assert_match "WARNING", stderr
		316	+ end
304	end	317	end