Raise ArgumentError for unsupported keywords [skip ci]

Andrew Kane
1 parent 51bf0d4b
Showing 1 changed file with 2 additions and 4 deletions Show diff stats
lib/searchkick/index.rb
@@ -197,16 +197,14 @@ module Searchkick
       options.delete(:refresh)
  
       if method_name
-        # TODO throw ArgumentError
-        Searchkick.warn("unsupported keywords: #{options.keys.map(&:inspect).join(", ")}") if options.any?
+        raise ArgumentError, "unsupported keywords: #{options.keys.map(&:inspect).join(", ")}" if options.any?
  
         # update
         import_scope(relation, method_name: method_name, scope: scope)
         self.refresh if refresh
         true
       elsif scoped && !full
-        # TODO throw ArgumentError
-        Searchkick.warn("unsupported keywords: #{options.keys.map(&:inspect).join(", ")}") if options.any?
+        raise ArgumentError, "unsupported keywords: #{options.keys.map(&:inspect).join(", ")}" if options.any?
  
         # reindex association
         import_scope(relation, scope: scope)
...	...	@@ -197,16 +197,14 @@ module Searchkick
197	197	options.delete(:refresh)
198	198
199	199	if method_name
200		- # TODO throw ArgumentError
201		- Searchkick.warn("unsupported keywords: #{options.keys.map(&:inspect).join(", ")}") if options.any?
	200	+ raise ArgumentError, "unsupported keywords: #{options.keys.map(&:inspect).join(", ")}" if options.any?
202	201
203	202	# update
204	203	import_scope(relation, method_name: method_name, scope: scope)
205	204	self.refresh if refresh
206	205	true
207	206	elsif scoped && !full
208		- # TODO throw ArgumentError
209		- Searchkick.warn("unsupported keywords: #{options.keys.map(&:inspect).join(", ")}") if options.any?
	207	+ raise ArgumentError, "unsupported keywords: #{options.keys.map(&:inspect).join(", ")}" if options.any?
210	208
211	209	# reindex association
212	210	import_scope(relation, scope: scope)
...	...