Separate method for tries [skip ci]

Andrew Kane
1 parent 3f6d9d24
Showing 1 changed file with 15 additions and 8 deletions Show diff stats
lib/searchkick/index.rb
@@ -432,7 +432,6 @@ module Searchkick
             method_name: method_name ? method_name.to_s : nil
           )
         else
-          retries = 0
           records = records.select(&:should_index?)
           delete_records =
@@ -443,7 +442,7 @@ module Searchkick
               []
             end
-          begin
+          with_retries do
             # bulk reindex
             possibly_bulk do
               if records.any?
@@ -451,17 +450,25 @@ module Searchkick
               end
               bulk_delete(delete_records) if delete_records.any?
             end
-          rescue Faraday::ClientError => e
-            if retries < 1
-              retries += 1
-              retry
-            end
-            raise e
           end
         end
       end
     end
+    def with_retries
+      retries = 0
+
+      begin
+        yield
+      rescue Faraday::ClientError => e
+        if retries < 1
+          retries += 1
+          retry
+        end
+        raise e
+      end
+    end
+
     # use bulk if no callbacks value set
     def possibly_bulk
       if Searchkick.callbacks_value