Added load: {dumpable: true} option - closes #887

Andrew Kane
1 parent 70b0ffdf
Showing 3 changed files with 10 additions and 1 deletions Show diff stats
CHANGELOG.md
lib/searchkick/results.rb
test/marshal_test.rb
 ## 2.2.1 [unreleased]
  
 - Added `avg`, `cardinality`, `max`, `min`, and `sum` aggregations
+- Added `load: {dumpable: true}` option
 - Accept string for `exclude` option
  
 ## 2.2.0
@@ -33,7 +33,7 @@ module Searchkick
           # sort
           hits.map do |hit|
             result = results[hit["_type"]][hit["_id"].to_s]
-            if result
+            if result && !(options[:load].is_a?(Hash) && options[:load][:dumpable])
               unless result.respond_to?(:search_hit)
                 result.define_singleton_method(:search_hit) do
                   hit
@@ -0,0 +1,8 @@
+require_relative "test_helper"
+
+class MarshalTest < Minitest::Test
+  def test_marshal
+    store_names ["Product A"]
+    assert Marshal.dump(Product.search("*", load: {dumpable: true}).results)
+  end
+end
1	1	## 2.2.1 [unreleased]
2	2
3	3	- Added `avg`, `cardinality`, `max`, `min`, and `sum` aggregations
	4	+- Added `load: {dumpable: true}` option
4	5	- Accept string for `exclude` option
5	6
6	7	## 2.2.0
...	...
...	...	@@ -33,7 +33,7 @@ module Searchkick
33	33	# sort
34	34	hits.map do \|hit\|
35	35	result = results[hit["_type"]][hit["_id"].to_s]
36		- if result
	36	+ if result && !(options[:load].is_a?(Hash) && options[:load][:dumpable])
37	37	unless result.respond_to?(:search_hit)
38	38	result.define_singleton_method(:search_hit) do
39	39	hit
...	...
...	...	@@ -0,0 +1,8 @@
	1	+require_relative "test_helper"
	2	+
	3	+class MarshalTest < Minitest::Test
	4	+ def test_marshal
	5	+ store_names ["Product A"]
	6	+ assert Marshal.dump(Product.search("*", load: {dumpable: true}).results)
	7	+ end
	8	+end
...	...