No longer require synonyms to be lowercase - #912

Andrew Kane
1 parent 1fb35cc0
Showing 4 changed files with 8 additions and 1 deletions Show diff stats
CHANGELOG.md
lib/searchkick/index_options.rb
test/synonyms_test.rb
test/test_helper.rb
 ## 2.2.2 [unreleased]
 - Added `queue_name` option
+- No longer require synonyms to be lowercase
 ## 2.2.1
@@ -167,7 +167,7 @@ module Searchkick
         if synonyms.any?
           settings[:analysis][:filter][:searchkick_synonym] = {
             type: "synonym",
-            synonyms: synonyms.select { |s| s.size > 1 }.map { |s| s.is_a?(Array) ? s.join(",") : s }
+            synonyms: synonyms.select { |s| s.size > 1 }.map { |s| s.is_a?(Array) ? s.join(",") : s }.map(&:downcase)
           }
           # choosing a place for the synonym filter when stemming is not easy
           # https://groups.google.com/forum/#!topic/elasticsearch/p7qcQlgHdB8
@@ -59,4 +59,9 @@ class SynonymsTest &lt; Minitest::Test
     assert_search "Halogen Lamp", ["Lightbulb"]
     assert_search "onions", ["Green Onions"]
   end
+
+  def test_case
+    store_names ["Uppercase"]
+    assert_search "lowercase", ["Uppercase"]
+  end
 end
@@ -372,6 +372,7 @@ class Product
       ["qtip", "cottonswab"],
       ["burger", "hamburger"],
       ["bandaid", "bandag"],
+      ["UPPERCASE", "lowercase"],
       "lightbulb => led,lightbulb",
       "lightbulb => halogenlamp"
     ],
1	## 2.2.2 [unreleased]	1	## 2.2.2 [unreleased]
2		2
3	- Added `queue_name` option	3	- Added `queue_name` option
		4	+- No longer require synonyms to be lowercase
4		5
5	## 2.2.1	6	## 2.2.1
6		7
	@@ -167,7 +167,7 @@ module Searchkick		@@ -167,7 +167,7 @@ module Searchkick
167	if synonyms.any?	167	if synonyms.any?
168	settings[:analysis][:filter][:searchkick_synonym] = {	168	settings[:analysis][:filter][:searchkick_synonym] = {
169	type: "synonym",	169	type: "synonym",
170	- synonyms: synonyms.select { \|s\| s.size > 1 }.map { \|s\| s.is_a?(Array) ? s.join(",") : s }	170	+ synonyms: synonyms.select { \|s\| s.size > 1 }.map { \|s\| s.is_a?(Array) ? s.join(",") : s }.map(&:downcase)
171	}	171	}
172	# choosing a place for the synonym filter when stemming is not easy	172	# choosing a place for the synonym filter when stemming is not easy
173	# https://groups.google.com/forum/#!topic/elasticsearch/p7qcQlgHdB8	173	# https://groups.google.com/forum/#!topic/elasticsearch/p7qcQlgHdB8
	@@ -59,4 +59,9 @@ class SynonymsTest < Minitest::Test		@@ -59,4 +59,9 @@ class SynonymsTest < Minitest::Test
59	assert_search "Halogen Lamp", ["Lightbulb"]	59	assert_search "Halogen Lamp", ["Lightbulb"]
60	assert_search "onions", ["Green Onions"]	60	assert_search "onions", ["Green Onions"]
61	end	61	end
		62	+
		63	+ def test_case
		64	+ store_names ["Uppercase"]
		65	+ assert_search "lowercase", ["Uppercase"]
		66	+ end
62	end	67	end