From 642ec5190da4e4c61281112c798efe076035bae8 Mon Sep 17 00:00:00 2001
From: Andrew Kane <andrew@chartkick.com>
Date: Tue, 17 Mar 2020 16:08:36 -0700
Subject: [PATCH] Warn for unsupported keywords - #1391

---
 lib/searchkick/index.rb | 6 ++++++
 test/reindex_test.rb    | 6 ++++++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/lib/searchkick/index.rb b/lib/searchkick/index.rb
index 2a38ccd..48beede 100644
--- a/lib/searchkick/index.rb
+++ b/lib/searchkick/index.rb
@@ -187,11 +187,17 @@ module Searchkick
       options.delete(:refresh)
 
       if method_name
+        # TODO throw ArgumentError
+        Searchkick.warn("unsupported keywords: #{options.keys.map(&:inspect).join(", ")}") if options.any?
+
         # update
         import_scope(relation, method_name: method_name, scope: scope)
         self.refresh if refresh
         true
       elsif scoped && !full
+        # TODO throw ArgumentError
+        Searchkick.warn("unsupported keywords: #{options.keys.map(&:inspect).join(", ")}") if options.any?
+
         # reindex association
         import_scope(relation, scope: scope)
         self.refresh if refresh
diff --git a/test/reindex_test.rb b/test/reindex_test.rb
index 906a397..93d4f83 100644
--- a/test/reindex_test.rb
+++ b/test/reindex_test.rb
@@ -92,4 +92,10 @@ class ReindexTest < Minitest::Test
   def test_refresh_full_reindex
     Product.reindex(refresh: true)
   end
+
+  def test_partial_async
+    store_names ["Product A"]
+    # warn for now
+    Product.reindex(:search_name, async: true)
+  end
 end
--
libgit2 0.21.0